From 867e58744bc55c8ba8235109cf3fc12a1bc0756e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Lothar=20Wa=C3=9Fmann?= Date: Fri, 9 Oct 2015 11:45:21 +0200 Subject: [PATCH 1/1] gpio: use appropriate return values for cmd handler --- common/cmd_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cmd_gpio.c b/common/cmd_gpio.c index 65d6df451c..58d8125f84 100644 --- a/common/cmd_gpio.c +++ b/common/cmd_gpio.c @@ -186,7 +186,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) ret = gpio_request(gpio, "cmd_gpio"); if (ret && ret != -EBUSY) { printf("gpio: requesting pin %u failed\n", gpio); - return -1; + return CMD_RET_FAILURE; } /* finally, let's do it: set direction and exec command */ @@ -208,7 +208,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) if (ret != -EBUSY) gpio_free(gpio); - return value; + return (ret && ret != -EBUSY) ? CMD_RET_FAILURE : CMD_RET_SUCCESS; } U_BOOT_CMD(gpio, 4, 0, do_gpio, -- 2.39.2