From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 2 Jul 2015 15:58:21 +0000 (+0200)
Subject: net-RDS: Delete an unnecessary check before the function call "module_put"
X-Git-Tag: v4.2-rc3~33^2~42
X-Git-Url: https://git.kernelconcepts.de/?a=commitdiff_plain;h=f6e1c91666990d06ba37c76129495c724202144d;p=karo-tx-linux.git

net-RDS: Delete an unnecessary check before the function call "module_put"

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/rds/transport.c b/net/rds/transport.c
index 8b4a6cd2c3a7..83498e1c75b8 100644
--- a/net/rds/transport.c
+++ b/net/rds/transport.c
@@ -73,7 +73,7 @@ EXPORT_SYMBOL_GPL(rds_trans_unregister);
 
 void rds_trans_put(struct rds_transport *trans)
 {
-	if (trans && trans->t_owner)
+	if (trans)
 		module_put(trans->t_owner);
 }