]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net/mlx4_en: Explicitly set no vlan tags in WQE ctrl segment when no vlan is present
authorJack Morgenstein <jackm@dev.mellanox.co.il>
Tue, 27 Oct 2015 15:36:19 +0000 (17:36 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Oct 2015 03:27:09 +0000 (20:27 -0700)
commit092bf0fc80f5fb7928244ad63d8a2a8df8a72a3e
tree030ae6e63221928815d8bdc87cd95e869c2782cc
parente407f39afdc0741dcf20aed100b8e738ccab7cb1
net/mlx4_en: Explicitly set no vlan tags in WQE ctrl segment when no vlan is present

We do not set the ins_vlan field to zero when no vlan id is present in the packet.

Since WQEs in the TX ring are not zeroed out between uses, this oversight
could result in having vlan flags present in the WQE ctrl segment when no
vlan is preset.

Fixes: e38af4faf01d ('net/mlx4_en: Add support for hardware accelerated 802.1ad vlan')
Reported-by: Gideon Naim <gideonn@mellanox.com>
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_tx.c