]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Input: goodix - fix variable length array warning
authorIrina Tirdea <irina.tirdea@intel.com>
Tue, 9 Jun 2015 18:03:15 +0000 (11:03 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 9 Jun 2015 18:23:26 +0000 (11:23 -0700)
commit0e0432f04ee5d73b45faefc7bbb63b75fcaefa42
treeaa69288f15d3fde705ed2810917d6026935d703e
parent0dfb35bd39d16ca2b69d5ddaa76a143c814eca45
Input: goodix - fix variable length array warning

Fix sparse warning:

drivers/input/touchscreen/goodix.c:182:26: warning: Variable length array is used.

Replace the variable length array with fixed length.

Some Goodix devices have maximum 5 touch points, while others have 10 touch
points. Using the maximum length (80 bytes) for all devices will lead to
wasting 40 bytes on stack when using devices with maximum 5 touch points.
However, that is preferable to using kmalloc which will use even more
resources.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/goodix.c