]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
tipc: fix inconsistent signal handling regression
authorErik Hugne <erik.hugne@ericsson.com>
Mon, 9 Mar 2015 09:43:42 +0000 (10:43 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Mar 2015 19:42:19 +0000 (15:42 -0400)
commit143fe22f50a8be855bba77b5b2dc9dd1a5982b1c
treeff4c064cb226d455ad2273770dec7432a58357ba
parent57ad7a0a81f3e9e619540ce9e31d5bd724b59a6e
tipc: fix inconsistent signal handling regression

Commit 9bbb4ecc6819 ("tipc: standardize recvmsg routine") changed
the sleep/wakeup behaviour for sockets entering recv() or accept().
In this process the order of reporting -EAGAIN/-EINTR was reversed.
This caused problems with wrong errno being reported back if the
timeout expires. The same problem happens if the socket is
nonblocking and recv()/accept() is called when the process have
pending signals. If there is no pending data read or connections to
accept, -EINTR will be returned instead of -EAGAIN.

Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Reported-by László Benedek <laszlo.benedek@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c