]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc: Add isync to copy_and_flush
authorMichael Neuling <michael.neuling@au1.ibm.com>
Wed, 24 Apr 2013 00:30:09 +0000 (00:30 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 26 Apr 2013 06:08:17 +0000 (16:08 +1000)
commit29ce3c5073057991217916abc25628e906911757
tree3913ec3eb5127dd1820935a46243b02c0bcd3e53
parent2171364d1a92d0a101b455315de7a92efb566008
powerpc: Add isync to copy_and_flush

In __after_prom_start we copy the kernel down to zero in two calls to
copy_and_flush.  After the first call (copy from 0 to copy_to_here:)
we jump to the newly copied code soon after.

Unfortunately there's no isync between the copy of this code and the
jump to it.  Hence it's possible that stale instructions could still be
in the icache or pipeline before we branch to it.

We've seen this on real machines and it's results in no console output
after:
  calling quiesce...
  returning from prom_init

The below adds an isync to ensure that the copy and flushing has
completed before any branching to the new instructions occurs.

Signed-off-by: Michael Neuling <mikey@neuling.org>
CC: <stable@vger.kernel.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/head_64.S