]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
toshiba_acpi: Do not register vendor backlight when acpi_video bl is available
authorHans de Goede <hdegoede@redhat.com>
Tue, 21 Apr 2015 10:01:32 +0000 (12:01 +0200)
committerDarren Hart <dvhart@linux.intel.com>
Fri, 24 Apr 2015 18:08:53 +0000 (11:08 -0700)
commit358d6a2c3ecae2b22c7d7e61f9d5672557446dfb
treef1b12dbaf7ce4b9fef4ed702650187a336b10b47
parentcdbff611940882b36d6964ced177bc167012f5c0
toshiba_acpi: Do not register vendor backlight when acpi_video bl is available

commit a39f46df33c6 ("toshiba_acpi: Fix regression caused by backlight extra
check code") causes the backlight to no longer work on the Toshiba Z30,
reverting that commit fixes this but restores the original issue fixed
by that commit.

Looking at the toshiba_acpi backlight code for a fix for this I noticed that
the toshiba code is the only code under platform/x86 which unconditionally
registers a vendor acpi backlight interface, without checking for acpi_video
backlight support first.

This commit adds the necessary checks bringing toshiba_acpi in line with the
other drivers, and fixing the Z30 regression without needing to revert the
commit causing it.

Chances are that there will be some Toshiba models which have a non working
acpi-video implementation while the toshiba vendor backlight interface does
work, this commit adds an empty dmi_id table where such systems can be added,
this is identical to how other drivers handle such systems.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1206036
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=86521
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-and-tested-by: Azael Avalos <coproscefalo@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/Kconfig
drivers/platform/x86/toshiba_acpi.c