]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pty: Ignore slave pty close() if never successfully opened
authorPeter Hurley <peter@hurleysoftware.com>
Wed, 30 Jan 2013 17:43:50 +0000 (12:43 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Feb 2013 23:40:28 +0000 (15:40 -0800)
commit699390354da6c258b65bf8fa79cfd5feaede50b6
treea2a1cde7fdc06a6ca684ac1c9bf57bef5d6f75ca
parent7acf6cd80b201f77371a5374a786144153629be8
pty: Ignore slave pty close() if never successfully opened

If the master and slave ptys are opened in parallel, the slave open
fails because the pty is still locked. This is as designed.
However, pty_close() is still called for the slave pty which sets
TTY_OTHER_CLOSED in the master pty. This can cause the master open
to fail as well.

Use a common pattern in other tty drivers by setting TTY_IO_ERROR
until the open is successful and only closing the pty if not set.

Note: the master pty always closes regardless of whether the open
was successful, so that proper cleanup can occur.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/pty.c