]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc/boot: Fix stack corruption in epapr entry point
authorJeremy Kerr <jk@ozlabs.org>
Wed, 11 Feb 2015 04:55:44 +0000 (12:55 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 16 Mar 2015 07:58:34 +0000 (18:58 +1100)
commit8c06f0d910ca628b657dc964a7347e70070dc7d6
tree2451a65aefa45403940a4aab08a750c2007ab009
parent90d1d44e0de0ec833634667bc1827303b2e1645e
powerpc/boot: Fix stack corruption in epapr entry point

Currently, a 64-bit little-endian zImage.epapr won't boot in epapr mode,
as we never return from platform_init.

Before entering C, we initialise our stack by setting r1 16 bytes below
the end of the _bss_stack:

  stwu r0,-16(r1) /* establish a stack frame */

However, the called function will save the caller's lr in the caller's
frame's lr save area, at -16(r1) to -32(r1).

This means that writes to the fdt variable will corrupt the saved link
register:

 0000000020c06018 l     O .bss   0000000000001000 _bss_stack
 0000000020c07018 l     O .bss   0000000000000008 fdt

We'll need at least 32 bytes in the initial stack frame, to handle the
LR save area. We bump this to 112 bytes, as that'll be the max required
by ABIv1.

Thanks to Alistair Popple for debugging help.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/boot/crt0.S