]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
usb: cleanup setting udev->removable from port_dev->connect_type
authorDan Williams <dan.j.williams@intel.com>
Wed, 21 May 2014 01:08:22 +0000 (18:08 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 May 2014 23:35:10 +0000 (16:35 -0700)
commita4204ff0bd576fc114357eed70e7c4e776ddf396
tree9322cdeb51cd3b509dd3c2a68d17ccbdc1f6e46e
parentd99f6b41308779244662109a9c2bad09a82e8ac6
usb: cleanup setting udev->removable from port_dev->connect_type

Once usb-acpi has set the port's connect type the usb_device's
->removable attribute can be set in the standard location
set_usb_port_removable().

This also changes behavior in the case where the firmware says that the
port connect type is unknown.  In that case just use the default setting
determined from the hub descriptor.

Note, we no longer pass udev->portnum to acpi_find_child_device() in the
root hub case since:
1/ the usb-core sets this to zero
2/ acpi always expects zero
...just pass zero.

Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c
drivers/usb/core/usb-acpi.c