]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
dm switch: simplify conditional in alloc_region_table()
authorTomohiro Kusumi <kusumi.tomohiro@gmail.com>
Wed, 28 Oct 2015 18:54:21 +0000 (03:54 +0900)
committerMike Snitzer <snitzer@redhat.com>
Sat, 31 Oct 2015 23:06:06 +0000 (19:06 -0400)
commitaad9ae4550755edc020b5c511a8b54f0104b2f47
treea94ce06ad5d8fe99c92a09c80ed60c7d8c8882a6
parentf49e869a61829b8ac6eb069b3824f738cd0146e6
dm switch: simplify conditional in alloc_region_table()

The variable sctx->nr_regions has type unsigned long and the variable
nr_regions has type sector_t.

Thus the variables may be different when overflow happens.
Changed the conditional to "if (nr_regions >= ULONG_MAX)".
Also move the assignment of nr_regions after sector_div()
and the sanity check which looks more sane.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-switch.c