]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: netcp: add missing of_node_put
authorJulia Lawall <julia.lawall@lip6.fr>
Sun, 25 Oct 2015 13:57:01 +0000 (14:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Oct 2015 05:08:10 +0000 (22:08 -0700)
commitbd252796852193277a07da505601a2f407c70e0b
tree21e43a186c99e667022099e1d0005cb23dbe23b6
parent8c387ebbaff8652943a1cbcab496aecadc6a8875
net: netcp: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression r.n;
expression r,e;
@@

 for_each_child_of_node(r,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/netcp_ethss.c