]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'
authorChristophe Jaillet <christophe.jaillet@wanadoo.fr>
Sun, 6 Aug 2017 22:00:17 +0000 (00:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Aug 2017 21:56:15 +0000 (14:56 -0700)
commiteb2a6b800c2d1336cce6709d48c42753a611c07b
treeee88ba3f9c9a2d5b90bab5ffab7458662583ecab
parentb925ef37b0a152b0c06aa43bc9204d0116f676d7
qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'

We allocate 'p_info->mfw_mb_cur' and 'p_info->mfw_mb_shadow' but we check
'p_info->mfw_mb_addr' instead of 'p_info->mfw_mb_cur'.

'p_info->mfw_mb_addr' is never 0, because it is initiliazed a few lines
above in 'qed_load_mcp_offsets()'.

Update the test and check the result of the 2 'kzalloc()' instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_mcp.c