]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sfc: Fix assignment of ip_summed for pre-allocated skbs
authorBen Hutchings <bhutchings@solarflare.com>
Sat, 25 Feb 2012 00:03:10 +0000 (00:03 +0000)
committerBen Hutchings <bhutchings@solarflare.com>
Sat, 25 Feb 2012 00:10:22 +0000 (00:10 +0000)
commitff3bc1e7527504a93710535611b2f812f3bb89bf
tree4fb3a0f723e71280315de1a9d2ab15e4cdb6fb66
parent3d7474734b220ccbf9997ea484d0bcd4f7ab8549
sfc: Fix assignment of ip_summed for pre-allocated skbs

When pre-allocating skbs for received packets, we set ip_summed =
CHECKSUM_UNNCESSARY.  We used to change it back to CHECKSUM_NONE when
the received packet had an incorrect checksum or unhandled protocol.

Commit bc8acf2c8c3e43fcc192762a9f964b3e9a17748b ('drivers/net: avoid
some skb->ip_summed initializations') mistakenly replaced the latter
assignment with a DEBUG-only assertion that ip_summed ==
CHECKSUM_NONE.  This assertion is always false, but it seems no-one
has exercised this code path in a DEBUG build.

Fix this by moving our assignment of CHECKSUM_UNNECESSARY into
efx_rx_packet_gro().

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/ethernet/sfc/rx.c