]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: host: max3421-hcd: Fix missing unlock in max3421_urb_enqueue()
authorDavid Mosberger-Tang <davidm@egauge.net>
Wed, 28 May 2014 22:09:16 +0000 (16:09 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 May 2014 23:57:34 +0000 (16:57 -0700)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Mosberger <davidm@egauge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/max3421-hcd.c

index 28abda14c5e26d319b50ebc6f819555c38e0deed..714f99faa14ad0e14abefb0fdfb51a9c58c6d9fe 100644 (file)
@@ -1545,8 +1545,10 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
        if (!max3421_ep) {
                /* gets freed in max3421_endpoint_disable: */
                max3421_ep = kzalloc(sizeof(struct max3421_ep), mem_flags);
-               if (!max3421_ep)
-                       return -ENOMEM;
+               if (!max3421_ep) {
+                       retval = -ENOMEM;
+                       goto out;
+               }
                max3421_ep->ep = urb->ep;
                max3421_ep->last_active = max3421_hcd->frame_number;
                urb->ep->hcpriv = max3421_ep;
@@ -1561,6 +1563,7 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
                wake_up_process(max3421_hcd->spi_thread);
        }
 
+out:
        spin_unlock_irqrestore(&max3421_hcd->lock, flags);
        return retval;
 }