]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
tipc: avoid double lock 'spin_lock:&seq->lock'
authorYing Xue <ying.xue@windriver.com>
Tue, 9 Dec 2014 07:17:56 +0000 (15:17 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Dec 2014 23:27:03 +0000 (18:27 -0500)
The commit fb9962f3cefe ("tipc: ensure all name sequences are properly
protected with its lock") involves below errors:

net/tipc/name_table.c:980 tipc_purge_publications() error: double lock 'spin_lock:&seq->lock'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/name_table.c

index aafa684c4db925a8ca5f985df52bbf495f2b85da..c8df0223371a7b86f971093fee1ac1ba47bffb26 100644 (file)
@@ -979,7 +979,7 @@ static void tipc_purge_publications(struct name_seq *seq)
        }
        hlist_del_init_rcu(&seq->ns_list);
        kfree(seq->sseqs);
-       spin_lock_bh(&seq->lock);
+       spin_unlock_bh(&seq->lock);
 
        kfree_rcu(seq, rcu);
 }