]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
hsi: controllers:remove redundant code
authorSanjeev Sharma <sanjeev_sharma@mentor.com>
Thu, 29 Oct 2015 10:04:55 +0000 (15:34 +0530)
committerSebastian Reichel <sre@kernel.org>
Fri, 30 Oct 2015 15:10:40 +0000 (16:10 +0100)
Use devm_ioremap_resource() in order to make the code simpler,
and remove redundant return value check of platform_get_resource()
because this value is alreadytaken care by devm_ioremap_resource()

Signed-off-by: Sanjeev Sharma <sanjeev_sharma@mentor.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/hsi/controllers/omap_ssi.c

index 089c6c3feb3ecb3349bfc6e0488ed32a72ad74ed..f6d3100b7a328dbd65d1be63d063ad595a915bdf 100644 (file)
@@ -295,27 +295,14 @@ static int __init ssi_get_iomem(struct platform_device *pd,
                const char *name, void __iomem **pbase, dma_addr_t *phy)
 {
        struct resource *mem;
                const char *name, void __iomem **pbase, dma_addr_t *phy)
 {
        struct resource *mem;
-       struct resource *ioarea;
        void __iomem *base;
        struct hsi_controller *ssi = platform_get_drvdata(pd);
 
        mem = platform_get_resource_byname(pd, IORESOURCE_MEM, name);
        void __iomem *base;
        struct hsi_controller *ssi = platform_get_drvdata(pd);
 
        mem = platform_get_resource_byname(pd, IORESOURCE_MEM, name);
-       if (!mem) {
-               dev_err(&pd->dev, "IO memory region missing (%s)\n", name);
-               return -ENXIO;
-       }
-       ioarea = devm_request_mem_region(&ssi->device, mem->start,
-                                       resource_size(mem), dev_name(&pd->dev));
-       if (!ioarea) {
-               dev_err(&pd->dev, "%s IO memory region request failed\n",
-                                                               mem->name);
-               return -ENXIO;
-       }
-       base = devm_ioremap(&ssi->device, mem->start, resource_size(mem));
-       if (!base) {
-               dev_err(&pd->dev, "%s IO remap failed\n", mem->name);
-               return -ENXIO;
-       }
+       base = devm_ioremap_resource(&ssi->device, mem);
+       if (IS_ERR(base))
+               return PTR_ERR(base);
+
        *pbase = base;
 
        if (phy)
        *pbase = base;
 
        if (phy)