]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: phy: mdio-sun4i: don't select REGULATOR
authorBeniamino Galvani <b.galvani@gmail.com>
Fri, 5 Sep 2014 22:28:23 +0000 (00:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 7 Sep 2014 23:12:03 +0000 (16:12 -0700)
The mdio-sun4i driver automatically selects REGULATOR and
REGULATOR_FIXED_VOLTAGE because it uses the regulator API. But a
driver selecting a subsystem increases the chance of generating
circular Kconfig dependencies, especially when other drivers depend on
the selected symbol.

Since the regulator API functions are replaced with no-ops when
REGULATOR is disabled, the driver can be built successfully even
without regulator support and so those 'select' dependencies can be
safely dropped.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/Kconfig

index 28437ab9c7bde976b9fd7468a2a109f21a817f24..14afa4f2442427131396e4690cb46d3eceec6c2d 100644 (file)
@@ -159,8 +159,6 @@ config MDIO_OCTEON
 config MDIO_SUN4I
        tristate "Allwinner sun4i MDIO interface support"
        depends on ARCH_SUNXI
-       select REGULATOR
-       select REGULATOR_FIXED_VOLTAGE
        help
          This driver supports the MDIO interface found in the network
          interface units of the Allwinner SoC that have an EMAC (A10,