USB: storage: ene_ub6250: Use kmemdup instead of kmalloc + memcpy

This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 1bfc9a6cab5f7fad815b8f92feb5b50e7adceba8..ef6efb55dc312f2c482b52731053be317d16c582 100644 (file)
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -1928,11 +1928,10 @@ static int ene_load_bincode(struct us_data *us, unsigned char flag)
                usb_stor_dbg(us, "load firmware %s failed\n", fw_name);
                goto nofw;
        }
-       buf = kmalloc(sd_fw->size, GFP_KERNEL);
+       buf = kmemdup(sd_fw->data, sd_fw->size, GFP_KERNEL);
        if (buf == NULL)
                goto nofw;
 
-       memcpy(buf, sd_fw->data, sd_fw->size);
        memset(bcb, 0, sizeof(struct bulk_cb_wrap));
        bcb->Signature = cpu_to_le32(US_BULK_CB_SIGN);
        bcb->DataTransferLength = sd_fw->size;