]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
target: Minimize SCSI header #include directives
authorBart Van Assche <bart.vanassche@sandisk.com>
Fri, 8 May 2015 08:11:12 +0000 (10:11 +0200)
committerJames Bottomley <JBottomley@Odin.com>
Tue, 2 Jun 2015 15:03:25 +0000 (08:03 -0700)
Only include SCSI initiator header files in target code that needs
these header files, namely the SCSI pass-through code and the tcm_loop
driver. Change SCSI_SENSE_BUFFERSIZE into TRANSPORT_SENSE_BUFFER in
target code because the former is intended for initiator code and the
latter for target code. With this patch the only initiator include
directives in target code that remain are as follows:

$ git grep -nHE 'include .scsi/(scsi.h|scsi_host.h|scsi_device.h|scsi_cmnd.h)' drivers/target drivers/infiniband/ulp/{isert,srpt} drivers/usb/gadget/legacy/tcm_*.[ch] drivers/{vhost,xen} include/{target,trace/events/target.h}
drivers/target/loopback/tcm_loop.c:29:#include <scsi/scsi.h>
drivers/target/loopback/tcm_loop.c:31:#include <scsi/scsi_host.h>
drivers/target/loopback/tcm_loop.c:32:#include <scsi/scsi_device.h>
drivers/target/loopback/tcm_loop.c:33:#include <scsi/scsi_cmnd.h>
drivers/target/target_core_pscsi.c:39:#include <scsi/scsi_device.h>
drivers/target/target_core_pscsi.c:40:#include <scsi/scsi_host.h>
drivers/xen/xen-scsiback.c:52:#include <scsi/scsi_host.h> /* SG_ALL */

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
36 files changed:
Documentation/target/tcm_mod_builder.py
drivers/infiniband/ulp/srpt/ib_srpt.c
drivers/infiniband/ulp/srpt/ib_srpt.h
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target_device.c
drivers/target/iscsi/iscsi_target_tmr.c
drivers/target/sbp/sbp_target.c
drivers/target/target_core_alua.c
drivers/target/target_core_device.c
drivers/target/target_core_fabric_lib.c
drivers/target/target_core_file.c
drivers/target/target_core_iblock.c
drivers/target/target_core_pr.c
drivers/target/target_core_pscsi.c
drivers/target/target_core_pscsi.h
drivers/target/target_core_rd.c
drivers/target/target_core_sbc.c
drivers/target/target_core_spc.c
drivers/target/target_core_stat.c
drivers/target/target_core_tmr.c
drivers/target/target_core_tpg.c
drivers/target/target_core_transport.c
drivers/target/target_core_ua.c
drivers/target/target_core_user.c
drivers/target/target_core_xcopy.c
drivers/target/tcm_fc/tfc_cmd.c
drivers/target/tcm_fc/tfc_conf.c
drivers/target/tcm_fc/tfc_io.c
drivers/target/tcm_fc/tfc_sess.c
drivers/usb/gadget/legacy/tcm_usb_gadget.c
drivers/usb/gadget/legacy/tcm_usb_gadget.h
drivers/vhost/scsi.c
drivers/xen/xen-scsiback.c
include/target/iscsi/iscsi_target_core.h
include/target/target_core_base.h
include/trace/events/target.h

index 2ba71cea01723cf3216ef4e95708789b6e0cc9f2..6085e1f19c9d59fa49b5a3d4d369da6426ae526e 100755 (executable)
@@ -503,11 +503,8 @@ def tcm_mod_dump_fabric_ops(proto_ident, fabric_mod_dir_var, fabric_mod_name):
        buf += "#include <linux/string.h>\n"
        buf += "#include <linux/ctype.h>\n"
        buf += "#include <asm/unaligned.h>\n"
-       buf += "#include <scsi/scsi.h>\n"
-       buf += "#include <scsi/scsi_host.h>\n"
-       buf += "#include <scsi/scsi_device.h>\n"
-       buf += "#include <scsi/scsi_cmnd.h>\n"
-       buf += "#include <scsi/libfc.h>\n\n"
+       buf += "#include <scsi/scsi_common.h>\n"
+       buf += "#include <scsi/scsi_proto.h>\n"
        buf += "#include <target/target_core_base.h>\n"
        buf += "#include <target/target_core_fabric.h>\n"
        buf += "#include <target/target_core_configfs.h>\n\n"
index 9b84b4c0a000a32bdc896d6142fb63c7d5b13a3a..af70d39361ecc1e1484608a2382b5d0dd152d684 100644 (file)
@@ -41,6 +41,7 @@
 #include <linux/string.h>
 #include <linux/delay.h>
 #include <linux/atomic.h>
+#include <scsi/scsi_proto.h>
 #include <scsi/scsi_tcq.h>
 #include <target/configfs_macros.h>
 #include <target/target_core_base.h>
index 3dae156905de53c1f9e9c5f0717f4ef4c3729803..d85c0c2056257b0ffa9a19e49aa96dba0e33399e 100644 (file)
@@ -245,7 +245,7 @@ struct srpt_send_ioctx {
        u8                      n_rdma;
        u8                      n_rbuf;
        bool                    queue_status_only;
-       u8                      sense_data[SCSI_SENSE_BUFFERSIZE];
+       u8                      sense_data[TRANSPORT_SENSE_BUFFER];
 };
 
 /**
index 34871a628b11124e093231694b0b0fb14b62de80..e0836c6e5d9ee1bfae02a9e58899551f8efd0730 100644 (file)
@@ -23,7 +23,7 @@
 #include <linux/module.h>
 #include <linux/idr.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi_device.h>
+#include <scsi/scsi_proto.h>
 #include <scsi/iscsi_proto.h>
 #include <scsi/scsi_tcq.h>
 #include <target/target_core_base.h>
index 34c3cd1b05ce8a40d9911da3815bc4a44b8a479c..5fabcd3d623f27fe9cd1f97b9d4c311157ade876 100644 (file)
@@ -17,7 +17,6 @@
  * GNU General Public License for more details.
  ******************************************************************************/
 
-#include <scsi/scsi_device.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
 
index b0224a77e26d3aff2549b71dd4b8c6a816213557..fe9a582ca6af4f4e83410dab6ecd22e28d74ff96 100644 (file)
@@ -17,7 +17,7 @@
  ******************************************************************************/
 
 #include <asm/unaligned.h>
-#include <scsi/scsi_device.h>
+#include <scsi/scsi_proto.h>
 #include <scsi/iscsi_proto.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
index 18b0f9703ff282a7c63229e822b6f2b8a01b26e2..ce81f17ad1ba5f97595ada370d8de40429eb9e0c 100644 (file)
@@ -30,7 +30,7 @@
 #include <linux/ctype.h>
 #include <linux/firewire.h>
 #include <linux/firewire-constants.h>
-#include <scsi/scsi.h>
+#include <scsi/scsi_proto.h>
 #include <scsi/scsi_tcq.h>
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 75cbde1f7c5b6e34ea7060011c2aca817e4e55f2..29904a9667a91a3d13e56c9ca0ad58740434af79 100644 (file)
@@ -28,8 +28,7 @@
 #include <linux/configfs.h>
 #include <linux/export.h>
 #include <linux/file.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
+#include <scsi/scsi_proto.h>
 #include <asm/unaligned.h>
 
 #include <target/target_core_base.h>
index 7faa6aef9a4d5429cbf1d3810ebb181f7a911beb..2dd7ea373c5872b35703b44e71dac8984e186de3 100644 (file)
@@ -35,8 +35,8 @@
 #include <linux/export.h>
 #include <net/sock.h>
 #include <net/tcp.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_device.h>
+#include <scsi/scsi_common.h>
+#include <scsi/scsi_proto.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 35bfe77160d86828b6511034787862f74788addc..fdf31ef02f8a34da5fac5257523cac103146588f 100644 (file)
@@ -29,8 +29,6 @@
 #include <linux/ctype.h>
 #include <linux/spinlock.h>
 #include <linux/export.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
index f7e6e51aed3614aa35e8a58c0bb1d2cfcc462141..169f33c5810261e96daf63d45f4fbfaf164390c2 100644 (file)
@@ -31,8 +31,7 @@
 #include <linux/spinlock.h>
 #include <linux/module.h>
 #include <linux/falloc.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
+#include <scsi/scsi_proto.h>
 #include <asm/unaligned.h>
 
 #include <target/target_core_base.h>
index 1b7947c2510fc8c65872127738c83ccbb34cf6a3..31ed331a75dc648703b11c5004d34455a388c316 100644 (file)
@@ -35,8 +35,7 @@
 #include <linux/genhd.h>
 #include <linux/file.h>
 #include <linux/module.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
+#include <scsi/scsi_proto.h>
 #include <asm/unaligned.h>
 
 #include <target/target_core_base.h>
index c1aa9655e96ec13881bdee2040254887fde0e903..83d50b3f3e21343d82e125149b569fd1def76e43 100644 (file)
@@ -28,8 +28,7 @@
 #include <linux/spinlock.h>
 #include <linux/list.h>
 #include <linux/file.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
+#include <scsi/scsi_proto.h>
 #include <asm/unaligned.h>
 
 #include <target/target_core_base.h>
index f6c954c4635f5dab27ac24ea117dd284561c836a..0a3ed787b8246e2a13a64d2e21ad36cce8fa5e92 100644 (file)
@@ -36,9 +36,7 @@
 #include <linux/module.h>
 #include <asm/unaligned.h>
 
-#include <scsi/scsi.h>
 #include <scsi/scsi_device.h>
-#include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_host.h>
 #include <scsi/scsi_tcq.h>
 
index 1bd757dff8eee3806cae1d3da6ce33804e5deb17..8fee9b0a88e2a24e394b65532db9d493f28e2de4 100644 (file)
 #define PS_TIMEOUT_OTHER       (500*HZ)
 
 #include <linux/device.h>
-#include <scsi/scsi_driver.h>
-#include <scsi/scsi_device.h>
 #include <linux/kref.h>
 #include <linux/kobject.h>
 
+struct scsi_device;
+
 struct pscsi_plugin_task {
-       unsigned char pscsi_sense[SCSI_SENSE_BUFFERSIZE];
+       unsigned char pscsi_sense[TRANSPORT_SENSE_BUFFER];
        int     pscsi_direction;
        int     pscsi_result;
        u32     pscsi_resid;
index a263bf5fab8d4538384f557aef1a3df7df3d9792..8882686a12c07ed47d8f2f0b38ee8e0262d21ffb 100644 (file)
@@ -29,8 +29,7 @@
 #include <linux/timer.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
+#include <scsi/scsi_proto.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 8855781ac653026aa0b513340b150e5f33f05f28..39a95ada371bc96dcf5f62c2d3affc87c17e7830 100644 (file)
@@ -25,7 +25,7 @@
 #include <linux/ratelimit.h>
 #include <linux/crc-t10dif.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi.h>
+#include <scsi/scsi_proto.h>
 #include <scsi/scsi_tcq.h>
 
 #include <target/target_core_base.h>
index 7912aa1243857a8968dcff5fa0f643b8e249dd6e..52ea640274f4fde0dd387866842c3aac3fcf77a3 100644 (file)
@@ -24,7 +24,8 @@
 #include <linux/module.h>
 #include <asm/unaligned.h>
 
-#include <scsi/scsi.h>
+#include <scsi/scsi_proto.h>
+#include <scsi/scsi_common.h>
 #include <scsi/scsi_tcq.h>
 
 #include <target/target_core_base.h>
index 03538994d2f7e1ee817d5b594fd33174079abaf3..40f6c13780414894a636cc43ef5b7eb6e0fea0d8 100644 (file)
@@ -33,9 +33,6 @@
 #include <linux/proc_fs.h>
 #include <linux/seq_file.h>
 #include <linux/configfs.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_device.h>
-#include <scsi/scsi_host.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 315ec3458eebc03a15a1715a065eee3dd72b9a2d..a5bb0c46e57e5c6398903141dcab6075ede4a1f8 100644 (file)
@@ -27,8 +27,6 @@
 #include <linux/spinlock.h>
 #include <linux/list.h>
 #include <linux/export.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 47f064415bf661fc2bb39b27762f870c4acabc56..84de757bd4580b04b1519934e71eb24606bbd3a6 100644 (file)
@@ -32,8 +32,7 @@
 #include <linux/export.h>
 #include <net/sock.h>
 #include <net/tcp.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
+#include <scsi/scsi_proto.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 3fe5cb240b6f6a5b4c8a3fb42396b77dd5701f74..d89793a377f7f23297ca688eb0181824337afcf6 100644 (file)
@@ -37,9 +37,7 @@
 #include <asm/unaligned.h>
 #include <net/sock.h>
 #include <net/tcp.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
-#include <scsi/scsi_tcq.h>
+#include <scsi/scsi_proto.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_backend.h>
index 1738b164698877d984d83239250b717aba83b2d7..e44cc94b12cb1b10ae3670f053fc0456255ac515 100644 (file)
@@ -25,8 +25,7 @@
 
 #include <linux/slab.h>
 #include <linux/spinlock.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
+#include <scsi/scsi_proto.h>
 
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
index dbc872a6c9816e95211f5b93bb9f623233d249ba..21b438ec470037977a867cc273e92881977d6d4d 100644 (file)
 #include <linux/spinlock.h>
 #include <linux/module.h>
 #include <linux/idr.h>
+#include <linux/kernel.h>
 #include <linux/timer.h>
 #include <linux/parser.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
 #include <linux/uio_driver.h>
 #include <net/genetlink.h>
+#include <scsi/scsi_common.h>
+#include <scsi/scsi_proto.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
 #include <target/target_core_backend.h>
index a600ff15dcfd1674140170b0808d494db64333ea..7a4486a054fcc7fcad067e3f9e3febc0288c5a16 100644 (file)
@@ -25,8 +25,7 @@
 #include <linux/spinlock.h>
 #include <linux/list.h>
 #include <linux/configfs.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_cmnd.h>
+#include <scsi/scsi_proto.h>
 #include <asm/unaligned.h>
 
 #include <target/target_core_base.h>
index edcafa4490c0850bfc01115357ce4e817773ee72..1bf78e7c994c8ef7ec3ecc58cbd7b6a2e3dfa782 100644 (file)
 #include <linux/hash.h>
 #include <linux/percpu_ida.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
-#include <scsi/scsi_device.h>
-#include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_tcq.h>
 #include <scsi/libfc.h>
 #include <scsi/fc_encode.h>
index 65dce1345966e392fe57c6bf7eadd80dc86351cd..86b699b94c7b615836ac38383554e1c83ff27af2 100644 (file)
 #include <linux/kernel.h>
 #include <linux/ctype.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
-#include <scsi/scsi_device.h>
-#include <scsi/scsi_cmnd.h>
 #include <scsi/libfc.h>
 
 #include <target/target_core_base.h>
index 583e755d809177d59953b991a9c8dd9068649205..fe585d1cce231c246150d5d639837fab68bbb09f 100644 (file)
 #include <linux/hash.h>
 #include <linux/ratelimit.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
-#include <scsi/scsi_device.h>
-#include <scsi/scsi_cmnd.h>
 #include <scsi/libfc.h>
 #include <scsi/fc_encode.h>
 
index ccee7e332a4d4900af26527d4e6d4141a679206d..f2a616d4f2c481ef568abfa5faff1a0063ebf36e 100644 (file)
 #include <linux/rculist.h>
 #include <linux/kref.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi.h>
-#include <scsi/scsi_host.h>
-#include <scsi/scsi_device.h>
-#include <scsi/scsi_cmnd.h>
 #include <scsi/libfc.h>
 
 #include <target/target_core_base.h>
index 8b80addc4ce6a5aaae4a330f4e27abd3ea67c5f8..789b047a18ab4a77a1d5aa336c6dd433480955fd 100644 (file)
@@ -16,7 +16,6 @@
 #include <linux/usb/composite.h>
 #include <linux/usb/gadget.h>
 #include <linux/usb/storage.h>
-#include <scsi/scsi.h>
 #include <scsi/scsi_tcq.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
index 8289219925b87dd7b99bedd3f5c2b4205f401862..9fb3544cc80f088d547d264945944043508418e3 100644 (file)
@@ -6,7 +6,6 @@
 #include <linux/usb/composite.h>
 #include <linux/usb/uas.h>
 #include <linux/usb/storage.h>
-#include <scsi/scsi.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
 
index 5e19bb53b3a99a4ccc93696bf9792a4f4f1ad7c4..08419756e98be5b47827b220599c2ae10ded3aec 100644 (file)
@@ -37,7 +37,8 @@
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
 #include <asm/unaligned.h>
-#include <scsi/scsi.h>
+#include <scsi/scsi_common.h>
+#include <scsi/scsi_proto.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
 #include <target/target_core_fabric_configfs.h>
index b7f51504f85adc1b5d19d33e48d066bdd60684c5..39223c3e99ad5277a3bc525647b7a58f7df668f8 100644 (file)
 
 #include <generated/utsrelease.h>
 
-#include <scsi/scsi.h>
-#include <scsi/scsi_dbg.h>
-#include <scsi/scsi_eh.h>
-#include <scsi/scsi_tcq.h>
+#include <scsi/scsi_host.h> /* SG_ALL */
 
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
index 54e7af301888f00550a05b872e4c8a5eaf92e51c..006983b296dd6da3afa466e43f40ec0699cad36f 100644 (file)
@@ -5,7 +5,6 @@
 #include <linux/configfs.h>
 #include <net/sock.h>
 #include <net/tcp.h>
-#include <scsi/scsi_cmnd.h>
 #include <scsi/iscsi_proto.h>
 #include <target/target_core_base.h>
 
index 0203774290433580c8b787606eee27e0e12c09a3..aec6f6a4477c79454af758817537dd8d3a3300b8 100644 (file)
@@ -6,7 +6,6 @@
 #include <linux/dma-mapping.h>
 #include <linux/blkdev.h>
 #include <linux/percpu_ida.h>
-#include <scsi/scsi_cmnd.h>
 #include <net/sock.h>
 #include <net/tcp.h>
 
@@ -25,7 +24,7 @@
  * From include/scsi/scsi_cmnd.h:SCSI_SENSE_BUFFERSIZE, currently
  * defined 96, but the real limit is 252 (or 260 including the header)
  */
-#define TRANSPORT_SENSE_BUFFER                 SCSI_SENSE_BUFFERSIZE
+#define TRANSPORT_SENSE_BUFFER                 96
 /* Used by transport_send_check_condition_and_sense() */
 #define SPC_SENSE_KEY_OFFSET                   2
 #define SPC_ADD_SENSE_LEN_OFFSET               7
index 04c3c6efdcc22d1a1a787d94b3686440521b9ff9..50fea660c0f89cfd325f6c3c22bf108d534468de 100644 (file)
@@ -6,7 +6,7 @@
 
 #include <linux/tracepoint.h>
 #include <linux/trace_seq.h>
-#include <scsi/scsi.h>
+#include <scsi/scsi_proto.h>
 #include <scsi/scsi_tcq.h>
 #include <target/target_core_base.h>