]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
rds: prevent dereference of a NULL device in rds_iw_laddr_check
authorSasha Levin <sasha.levin@oracle.com>
Sun, 30 Mar 2014 00:39:35 +0000 (20:39 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Mar 2014 20:25:52 +0000 (16:25 -0400)
Binding might result in a NULL device which is later dereferenced
without checking.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/iw.c

index 7826d46baa7038366872ec412d97ecd94eb1d13f..589935661d667d81b2f6159eb69c237f95329a63 100644 (file)
@@ -239,7 +239,8 @@ static int rds_iw_laddr_check(__be32 addr)
        ret = rdma_bind_addr(cm_id, (struct sockaddr *)&sin);
        /* due to this, we will claim to support IB devices unless we
           check node_type. */
-       if (ret || cm_id->device->node_type != RDMA_NODE_RNIC)
+       if (ret || !cm_id->device ||
+           cm_id->device->node_type != RDMA_NODE_RNIC)
                ret = -EADDRNOTAVAIL;
 
        rdsdebug("addr %pI4 ret %d node type %d\n",