]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
cosa: missing error code on failure in probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 12 Aug 2015 21:08:01 +0000 (00:08 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Aug 2015 23:53:11 +0000 (16:53 -0700)
If register_hdlc_device() fails, the current code returns 0 but we
should return an error code instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/cosa.c

index 7193b7304fdd3ed4b69c0125732d4a024d4a4b36..848ea6a399f236b14cc5d9a79dd38038e0331aec 100644 (file)
@@ -589,7 +589,8 @@ static int cosa_probe(int base, int irq, int dma)
                chan->netdev->base_addr = chan->cosa->datareg;
                chan->netdev->irq = chan->cosa->irq;
                chan->netdev->dma = chan->cosa->dma;
-               if (register_hdlc_device(chan->netdev)) {
+               err = register_hdlc_device(chan->netdev);
+               if (err) {
                        netdev_warn(chan->netdev,
                                    "register_hdlc_device() failed\n");
                        free_netdev(chan->netdev);