]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
target/pscsi: blk_make_request() returns an ERR_PTR()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 2 Nov 2011 15:48:15 +0000 (08:48 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 2 Nov 2011 15:58:47 +0000 (15:58 +0000)
The check is wrong here because blk_make_request() returns an
ERR_PTR() and it doesn't return NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_pscsi.c

index dad671dee9e92172c04142a7dfd4ae6dcc8d206c..f941b6232614994e2a8544e9c46b1d7d2c7e8e33 100644 (file)
@@ -1091,7 +1091,7 @@ static int pscsi_do_task(struct se_task *task)
 
                req = blk_make_request(pdv->pdv_sd->request_queue, hbio,
                                       GFP_KERNEL);
-               if (!req) {
+               if (IS_ERR(req)) {
                        pr_err("pSCSI: blk_make_request() failed\n");
                        goto fail;
                }