]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86/fpu, crypto x86/camellia_aesni_avx: Simplify the camellia_aesni_init() xfeature...
authorIngo Molnar <mingo@kernel.org>
Tue, 28 Apr 2015 07:59:44 +0000 (09:59 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 19 May 2015 13:47:56 +0000 (15:47 +0200)
commitce4f5f9b65ae3d630e375b5e406feca31f682886
treeea00e6506c3966da67de2f09b981e86338c325bb
parent91969d690f594f22c15055daf89cecd33584d65e
x86/fpu, crypto x86/camellia_aesni_avx: Simplify the camellia_aesni_init() xfeature checks

Use the new 'cpu_has_xfeatures()' function to query AVX CPU support.

This has the following advantages to the driver:

 - Decouples the driver from FPU internals: it's now only using <asm/fpu/api.h>.

 - Removes detection complexity from the driver, no more raw XGETBV instruction

 - Shrinks the code a bit:

     text    data     bss     dec     hex filename
     2128    2896       0    5024    13a0 camellia_aesni_avx_glue.o.before
     2067    2896       0    4963    1363 camellia_aesni_avx_glue.o.after

 - Standardizes feature name error message printouts across drivers

There are also advantages to the x86 FPU code: once all drivers
are decoupled from internals we can move them out of common
headers and we'll also be able to remove xcr.h.

Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/crypto/camellia_aesni_avx_glue.c