]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
pcnet: force ordering of descriptor accesses
authorPaul Burton <paul.burton@imgtec.com>
Mon, 7 Apr 2014 15:41:48 +0000 (16:41 +0100)
committerTom Rini <trini@ti.com>
Fri, 18 Apr 2014 14:42:30 +0000 (10:42 -0400)
commit6fb49e4aa08e5d4f4081840b0b30160e98becf27
treef67077f0f8ddc5c91eb5567feecabeeca4bb8bec
parenta354ddc3d7412c6d7cc702de60be32e580ccf348
pcnet: force ordering of descriptor accesses

The ordering of accesses to the rx & tx descriptors is important, yet
the send & recv functions accessed them via regular structure accesses.
This leaves the compiler with the opportunity to reorder those accesses
or to hoist them outside of loops. Prevent that from happening by using
readl & writel to access the descriptors. As a nice bonus, this removes
the need for the driver to care about endianness.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
drivers/net/pcnet.c