]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
mmc: sunxi: Fix misuse of gpio_direction_input()
authorAxel Lin <axel.lin@ingics.com>
Sat, 20 Dec 2014 03:41:25 +0000 (11:41 +0800)
committerHans de Goede <hdegoede@redhat.com>
Wed, 14 Jan 2015 13:56:36 +0000 (14:56 +0100)
commitb0c4ae1a5176632e17627f05ae54be1b1bea3082
treef5b5353291b4779cb9084b8889e0f0f0c5b2abc3
parent3f6242eb30ca768ba56d46c40a905ea25405d12d
mmc: sunxi: Fix misuse of gpio_direction_input()

It does not make sense to make gpio_direction_input() return the gpio input
status. The return value of gpio_direction_input() is inconsistent if
CONFIG_DM_GPIO is defined.
And we don't need to call gpio_direction_input() int sunxi_mmc_getcd().
Just init the gpio once in mmc_resource_init() is enough.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
drivers/gpio/sunxi_gpio.c
drivers/mmc/sunxi_mmc.c