]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
mtd: nand: omap_gpmc: fix error handling
authorGuido Martínez <guido@vanguardiasur.com.ar>
Fri, 2 Jan 2015 17:49:10 +0000 (14:49 -0300)
committerTom Rini <trini@ti.com>
Mon, 5 Jan 2015 21:40:18 +0000 (16:40 -0500)
commiteb54d2c70ce3b14e0c9ae141e216d5ad0b22d0dd
treeb784c3ad1724edba2388d6c6062471c1ad896100
parent001475a0f58f33c83646254ef46640556cd3fe77
mtd: nand: omap_gpmc: fix error handling

"err" was an unsigned variable, causing negative error codes to turn
into positive values, which are interpreted as an amount of succesfully
corrected bitflips (and thus not an error).

In particular, this resulted in that if the elm reports uncorrectable
errors (-EBADMSG), the MTD layer (and UBI) falsely succeeded.

Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Reviewed-by: Stefan Roese <sr@denx.de>
drivers/mtd/nand/omap_gpmc.c