]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
buildman: Fix the logic for the bloat command
authorSimon Glass <sjg@chromium.org>
Mon, 15 Sep 2014 02:23:16 +0000 (20:23 -0600)
committerSimon Glass <sjg@chromium.org>
Sun, 21 Sep 2014 18:03:07 +0000 (12:03 -0600)
This check should now be done whatever mode buildman is running in, since
we may be displaying information while building.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/buildman/control.py

index e97350f9a02d3ee5e411b670106e42ea53c26029..8b8c826002f51aca985e6d2b493e0c6f4692363f 100644 (file)
@@ -244,13 +244,13 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
         Print(GetActionSummary(options.summary, commits, board_selected,
                                 options))
 
         Print(GetActionSummary(options.summary, commits, board_selected,
                                 options))
 
+        # We can't show function sizes without board details at present
+        if options.show_bloat:
+            options.show_detail = True
         builder.SetDisplayOptions(options.show_errors, options.show_sizes,
                                   options.show_detail, options.show_bloat,
                                   options.list_error_boards)
         if options.summary:
         builder.SetDisplayOptions(options.show_errors, options.show_sizes,
                                   options.show_detail, options.show_bloat,
                                   options.list_error_boards)
         if options.summary:
-            # We can't show function sizes without board details at present
-            if options.show_bloat:
-                options.show_detail = True
             builder.ShowSummary(commits, board_selected)
         else:
             fail, warned = builder.BuildBoards(commits, board_selected,
             builder.ShowSummary(commits, board_selected)
         else:
             fail, warned = builder.BuildBoards(commits, board_selected,