From: Anatolij Gustschin <agust@denx.de>
Date: Sat, 30 Apr 2011 02:17:44 +0000 (+0000)
Subject: miiphy: miiphyutil.c: fix compile warning
X-Git-Tag: v2011.06-rc1~88
X-Git-Url: https://git.kernelconcepts.de/?p=karo-tx-uboot.git;a=commitdiff_plain;h=d67d5d529aa3a5c3c063a24585eeaedd5e0728eb

miiphy: miiphyutil.c: fix compile warning

Fix warning introduced while recent PHY Lib changes:

miiphyutil.c: In function 'miiphy_read':
miiphyutil.c:304: warning: comparison is always false due to limited range of data type

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Andy Fleming <afleming@freescale.com>
---

diff --git a/common/miiphyutil.c b/common/miiphyutil.c
index 243cae97a4..bcab74e73a 100644
--- a/common/miiphyutil.c
+++ b/common/miiphyutil.c
@@ -294,14 +294,18 @@ int miiphy_read(const char *devname, unsigned char addr, unsigned char reg,
 		 unsigned short *value)
 {
 	struct mii_dev *bus;
+	int ret;
 
 	bus = miiphy_get_active_dev(devname);
-	if (bus)
-		*value = bus->read(bus, addr, MDIO_DEVAD_NONE, reg);
-	else
+	if (!bus)
 		return 1;
 
-	return (*value < 0) ? 1 : 0;
+	ret = bus->read(bus, addr, MDIO_DEVAD_NONE, reg);
+	if (ret < 0)
+		return 1;
+
+	*value = (unsigned short)ret;
+	return 0;
 }
 
 /*****************************************************************************