]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
powerpc/espi: remove write command length check
authorShaohui Xie <Shaohui.Xie@freescale.com>
Thu, 11 Oct 2012 20:31:46 +0000 (20:31 +0000)
committerAndy Fleming <afleming@freescale.com>
Mon, 22 Oct 2012 20:52:46 +0000 (15:52 -0500)
Current espi controller driver assumes the command length of write command is
not equal to '1', it was made based on SPANSION SPI flash, but some SPI flash
driver such as SST does use write command length as '1', so write command on
SST SPI flash will not work. And the length check for write command is not
necessary for SPANSION, though it's harmless for SPANSION, it will stop write
operation on flashes like SST, so we remove the check.

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Signed-off-by: Andy Fleming <afleming@freescale.com>
drivers/spi/fsl_espi.c

index a1ebd330d7bae5c2cc5a0e1c82da06ac68bae50c..eb99e90becc9e27eb140e5b6f2ab9841ec63377b 100644 (file)
@@ -216,10 +216,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *data_out,
                        return 1;
                }
                memcpy(buffer, cmd_buf, cmd_len);
-               if (cmd_len != 1) {
-                       if (data_in == NULL)
-                               memcpy(buffer + cmd_len, data_out, data_len);
-               }
+               if (data_in == NULL)
+                       memcpy(buffer + cmd_len, data_out, data_len);
                break;
        case SPI_XFER_BEGIN | SPI_XFER_END:
                len = data_len;