]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
cgroup: fix an off-by-one bug which may trigger BUG_ON()
authorLi Zefan <lizefan@huawei.com>
Tue, 12 Mar 2013 22:36:00 +0000 (15:36 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 May 2013 03:08:22 +0000 (20:08 -0700)
commit1ef527a1111b2a206d39d2e23cf13819e329f8b4
tree9b56d869e5f3f7852ec6313935096219213bf884
parent928c5edbe6f7cb0d1c71bc2353d091bc5b114fe3
cgroup: fix an off-by-one bug which may trigger BUG_ON()

commit 3ac1707a13a3da9cfc8f242a15b2fae6df2c5f88 upstream.

The 3rd parameter of flex_array_prealloc() is the number of elements,
not the index of the last element.

The effect of the bug is, when opening cgroup.procs, a flex array will
be allocated and all elements of the array is allocated with
GFP_KERNEL flag, but the last one is GFP_ATOMIC, and if we fail to
allocate memory for it, it'll trigger a BUG_ON().

Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cgroup.c