]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86/boot: Declare error() as noreturn
authorKees Cook <keescook@chromium.org>
Sat, 6 May 2017 04:51:16 +0000 (21:51 -0700)
committerIngo Molnar <mingo@kernel.org>
Sun, 7 May 2017 08:59:05 +0000 (10:59 +0200)
commit60854a12d281e2fa25662fa32ac8022bbff17432
tree6a641c085b2a1b4e04a61f1b787b572019c9c610
parent121843eb02a6e2fa30aefab64bfe183c97230c75
x86/boot: Declare error() as noreturn

The compressed boot function error() is used to halt execution, but it
wasn't marked with "noreturn". This fixes that in preparation for
supporting kernel FORTIFY_SOURCE, which uses the noreturn annotation
on panic, and calls error(). GCC would warn about a noreturn function
calling a non-noreturn function:

  arch/x86/boot/compressed/misc.c: In function ‘fortify_panic’:
  arch/x86/boot/compressed/misc.c:416:1: warning: ‘noreturn’ function does return
   }
 ^

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Daniel Micay <danielmicay@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Link: http://lkml.kernel.org/r/20170506045116.GA2879@beast
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/boot/compressed/error.h