]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
quota: Don't write quota info in dquot_commit()
authorJan Kara <jack@suse.cz>
Thu, 31 Mar 2011 16:36:52 +0000 (18:36 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 23:53:30 +0000 (16:53 -0700)
commit8975a50e80906e43575b419f7849d251311a2067
treea8a01bd4f763bbfd96597b364e177fdb179a3fa3
parentb94738ff1cbcc97a8ec84eb23b7d0453082e44a9
quota: Don't write quota info in dquot_commit()

commit b03f24567ce7caf2420b8be4c6eb74c191d59a91 upstream.

There's no reason to write quota info in dquot_commit(). The writing is a
relict from the old days when we didn't have dquot_acquire() and
dquot_release() and thus dquot_commit() could have created / removed quota
structures from the file. These days dquot_commit() only updates usage counters
/ limits in quota structure and thus there's no need to write quota info.

This also fixes an issue with journaling filesystem which didn't reserve
enough space in the transaction for write of quota info (it could have been
dirty at the time of dquot_commit() because of a race with other operation
changing it).

Reported-and-tested-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/quota/dquot.c