]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
genirq/msi: Prevent overwriting domain name
authorThomas Gleixner <tglx@linutronix.de>
Mon, 19 Jun 2017 23:37:04 +0000 (01:37 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 22 Jun 2017 16:21:08 +0000 (18:21 +0200)
Prevent overwriting an already assigned domain name. Remove the extra check
for chip->name, because if domain->name is NULL overwriting it with NULL is
not a problem.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Link: http://lkml.kernel.org/r/20170619235443.510684976@linutronix.de
kernel/irq/msi.c

index fe4d48ec5bc4a708c42246bbe3b16e437c4683ec..9e3f1857c6bdb381ae74c6963c259501eaa8df43 100644 (file)
@@ -274,7 +274,8 @@ struct irq_domain *msi_create_irq_domain(struct fwnode_handle *fwnode,
 
        domain = irq_domain_create_hierarchy(parent, IRQ_DOMAIN_FLAG_MSI, 0,
                                             fwnode, &msi_domain_ops, info);
-       if (domain && info->chip && info->chip->name)
+
+       if (domain && !domain->name && info->chip)
                domain->name = info->chip->name;
 
        return domain;