]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
x86: HPET: convert WARN_ON to WARN_ON_ONCE
authorMatt Fleming <mjf@gentoo.org>
Sun, 2 Nov 2008 16:04:18 +0000 (16:04 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 13 Dec 2008 23:29:30 +0000 (15:29 -0800)
commit 1de5b0854623d30d01d72cd4ea323eb5f39d1f16 upstream.

It is possible to flood the console with call traces if the WARN_ON
condition is true because of the frequency with which this function is
called.

Signed-off-by: Matt Fleming <mjf@gentoo.org>
Cc: mingo@elte.hu
Cc: venkatesh.pallipadi@intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/kernel/hpet.c

index 73deaffadd036a578984bb8ad6e0455f1044558a..759e8da4ed3abae92085da0d4514556eb3cf7866 100644 (file)
@@ -283,7 +283,7 @@ static int hpet_legacy_next_event(unsigned long delta,
         * what we wrote hit the chip before we compare it to the
         * counter.
         */
-       WARN_ON((u32)hpet_readl(HPET_T0_CMP) != cnt);
+       WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt);
 
        return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0;
 }