]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: misc: usbtest: using the same data format among write/compare/output
authorPeter Chen <peter.chen@freescale.com>
Tue, 1 Sep 2015 01:48:00 +0000 (09:48 +0800)
committerFelipe Balbi <balbi@ti.com>
Sun, 27 Sep 2015 15:54:31 +0000 (10:54 -0500)
Using the same data format "buf[j] = (u8)(i + j)" among
write, compare buf, and console output stage.

Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/misc/usbtest.c

index 819b4b1f327b3a982c8d97cc4ccd3620186f4e9a..cac93b77f9a74c41d2e3cc14155ae194ec571db3 100644 (file)
@@ -1720,7 +1720,7 @@ static int ctrl_out(struct usbtest_dev *dev,
        for (i = 0; i < count; i++) {
                /* write patterned data */
                for (j = 0; j < len; j++)
-                       buf[j] = i + j;
+                       buf[j] = (u8)(i + j);
                retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
                                0x5b, USB_DIR_OUT|USB_TYPE_VENDOR,
                                0, 0, buf, len, USB_CTRL_SET_TIMEOUT);
@@ -1750,9 +1750,9 @@ static int ctrl_out(struct usbtest_dev *dev,
 
                /* fail if we can't verify */
                for (j = 0; j < len; j++) {
-                       if (buf[j] != (u8) (i + j)) {
+                       if (buf[j] != (u8)(i + j)) {
                                ERROR(dev, "ctrl_out, byte %d is %d not %d\n",
-                                       j, buf[j], (u8) i + j);
+                                       j, buf[j], (u8)(i + j));
                                retval = -EBADMSG;
                                break;
                        }