batman-adv: unify hash_entry field position in tt_local/global_entry

commit 93840ac40bb0d0f177ef8af74e64671be67e8c37 upstream.

Function tt_response_fill_table() actually uses a tt_local_entry pointer to
iterate either over the local or the global table entries (it depends on the
what hash table is passed as argument). To iterate over such entries the
hlist_for_each_entry_rcu() macro has to access their "hash_entry" field which
MUST be at the same position in both the tt_global/local_entry structures.

Reported-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h
index 25bd1db353700bd64439602e2523c59ad1448bf5..51a0db7f644933ecd23ad7ee0d033151dfac2441 100644 (file)
--- a/net/batman-adv/types.h
+++ b/net/batman-adv/types.h
@@ -223,22 +223,22 @@ struct socket_packet {
 
 struct tt_local_entry {
        uint8_t addr[ETH_ALEN];
+       struct hlist_node hash_entry;
        unsigned long last_seen;
        uint16_t flags;
        atomic_t refcount;
        struct rcu_head rcu;
-       struct hlist_node hash_entry;
 };
 
 struct tt_global_entry {
        uint8_t addr[ETH_ALEN];
+       struct hlist_node hash_entry; /* entry in the global table */
        struct orig_node *orig_node;
        uint8_t ttvn;
        uint16_t flags; /* only TT_GLOBAL_ROAM is used */
        unsigned long roam_at; /* time at which TT_GLOBAL_ROAM was set */
        atomic_t refcount;
        struct rcu_head rcu;
-       struct hlist_node hash_entry; /* entry in the global table */
 };
 
 struct tt_change_node {