]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: broadcom: bnx2x: make a couple of const arrays static
authorColin Ian King <colin.king@canonical.com>
Tue, 11 Jul 2017 10:52:23 +0000 (11:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Jul 2017 16:23:56 +0000 (09:23 -0700)
Don't populate various tables on the stack but make them static const.
Makes the object code smaller by nearly 200 bytes:

Before:
   text    data     bss     dec     hex filename
 113468   11200       0  124668   1e6fc bnx2x_ethtool.o

After:
   text    data     bss     dec     hex filename
 113129   11344       0  124473   1e639 bnx2x_ethtool.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c

index 43423744fdfa8151b2312bc84b41267965d6c92c..21bc4bed6b260462109e36e79769ac9d5ab5ea04 100644 (file)
@@ -2886,7 +2886,7 @@ static int bnx2x_test_nvram_tbl(struct bnx2x *bp,
 
 static int bnx2x_test_nvram(struct bnx2x *bp)
 {
-       const struct crc_pair nvram_tbl[] = {
+       static const struct crc_pair nvram_tbl[] = {
                {     0,  0x14 }, /* bootstrap */
                {  0x14,  0xec }, /* dir */
                { 0x100, 0x350 }, /* manuf_info */
@@ -2895,7 +2895,7 @@ static int bnx2x_test_nvram(struct bnx2x *bp)
                { 0x708,  0x70 }, /* manuf_key_info */
                {     0,     0 }
        };
-       const struct crc_pair nvram_tbl2[] = {
+       static const struct crc_pair nvram_tbl2[] = {
                { 0x7e8, 0x350 }, /* manuf_info2 */
                { 0xb38,  0xf0 }, /* feature_info */
                {     0,     0 }