]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
sh_eth: fix branch prediction in sh_eth_interrupt()
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thu, 29 Dec 2016 21:07:38 +0000 (00:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Dec 2016 03:16:06 +0000 (22:16 -0500)
IIUC, likely()/unlikely() should apply to the whole *if* statement's
expression, not a part of it  -- fix such expression in  sh_eth_interrupt()
accordingly...

Fixes: 283e38db65e7 ("sh_eth: Fix serialisation of interrupt disable with interrupt & NAPI handlers")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c

index f341c1bc7001678326985746bd0ce65d1572994a..0af7fc279c8560d130642e65a5e87a702699ee34 100644 (file)
@@ -1656,7 +1656,7 @@ static irqreturn_t sh_eth_interrupt(int irq, void *netdev)
        else
                goto out;
 
-       if (!likely(mdp->irq_enabled)) {
+       if (unlikely(!mdp->irq_enabled)) {
                sh_eth_write(ndev, 0, EESIPR);
                goto out;
        }