]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
hugetlb: fix error return for brk() entering a hugepage region
authorHugh Dickins <hugh@veritas.com>
Sun, 28 Oct 2007 21:22:25 +0000 (22:22 +0100)
committerAdrian Bunk <bunk@kernel.org>
Sun, 28 Oct 2007 21:22:25 +0000 (22:22 +0100)
The lats commit causes the wrong return value.
is_hugepage_only_range() is a boolean, so we should return
-EINVAL rather than 1.

Also - we can use "mm" instead of looking up "current->mm" again.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
mm/mmap.c

index a04576de325467bb44a4956b225bbff2210cf966..666932b09ea0d5b845ba49df89d4d6c3b140a7e8 100644 (file)
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1870,9 +1870,8 @@ unsigned long do_brk(unsigned long addr, unsigned long len)
        if ((addr + len) > TASK_SIZE || (addr + len) < addr)
                return -EINVAL;
 
-       error = is_hugepage_only_range(current->mm, addr, len);
-       if (error)
-               return error;
+       if (is_hugepage_only_range(mm, addr, len))
+               return -EINVAL;
 
        flags = VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags;