]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
gfs2: Avoid alignment hole in struct lm_lockname
authorAndreas Gruenbacher <agruenba@redhat.com>
Mon, 6 Mar 2017 17:58:42 +0000 (12:58 -0500)
committerBob Peterson <rpeterso@redhat.com>
Wed, 15 Mar 2017 14:06:07 +0000 (10:06 -0400)
Commit 88ffbf3e03 switches to using rhashtables for glocks, hashing over
the entire struct lm_lockname instead of its individual fields.  On some
architectures, struct lm_lockname contains a hole of uninitialized
memory due to alignment rules, which now leads to incorrect hash values.
Get rid of that hole.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
CC: <stable@vger.kernel.org> #v4.3+
fs/gfs2/incore.h

index c45084ac642d1929058ea5d903ad796d574a45cc..511e1ed7e2ded7b0a9dc9882cffe0b66c37c96a2 100644 (file)
@@ -207,7 +207,7 @@ struct lm_lockname {
        struct gfs2_sbd *ln_sbd;
        u64 ln_number;
        unsigned int ln_type;
-};
+} __packed __aligned(sizeof(int));
 
 #define lm_name_equal(name1, name2) \
         (((name1)->ln_number == (name2)->ln_number) && \