]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
nmi_watchdog: Fix undefined 'apic' build bug
authorDon Zickus <dzickus@redhat.com>
Fri, 19 Feb 2010 02:56:52 +0000 (21:56 -0500)
committerIngo Molnar <mingo@elte.hu>
Fri, 19 Feb 2010 22:04:13 +0000 (23:04 +0100)
Ingo provided me a config that fails to compile with:

  arch/x86/built-in.o: In function
  `arch_trigger_all_cpu_backtrace': (.text+0x17e78): undefined
  reference to `apic' make: *** [.tmp_vmlinux1] Error 1

I realized I changed the compile behaviour of the nmi code by
not wrapping it with CONFIG_LOCAL_APIC.  To fix this I add a
compile check for ARCH_HAS_NMI_WATCHDOG around
arch_trigger_all_cpu_backtrace.

Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: a.p.zijlstra@chello.nl
Cc: gorcunov@gmail.com
Cc: aris@redhat.com
LKML-Reference: <1266548212-24243-1-git-send-email-dzickus@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/apic/hw_nmi.c

index 312d772c5c351ccaa2ef1788d9c24fa7995c7c7e..0b4d205a6b8e1d7b13993ca76cb9407def17af27 100644 (file)
@@ -92,6 +92,7 @@ u64 hw_nmi_get_sample_period(void)
         return cpu_khz * 1000;
 }
 
+#ifdef ARCH_HAS_NMI_WATCHDOG
 void arch_trigger_all_cpu_backtrace(void)
 {
        int i;
@@ -108,6 +109,7 @@ void arch_trigger_all_cpu_backtrace(void)
                mdelay(1);
        }
 }
+#endif
 
 /* STUB calls to mimic old nmi_watchdog behaviour */
 #if defined(CONFIG_X86_LOCAL_APIC)