]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
iommu/amd: Signedness bug in acpihid_device_group()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 11 Apr 2016 07:14:46 +0000 (10:14 +0300)
committerJoerg Roedel <jroedel@suse.de>
Fri, 15 Apr 2016 10:09:10 +0000 (12:09 +0200)
"devid" needs to be signed for the error handling to work.

Fixes: b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID devices')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd_iommu.c

index c430c10fb645a1c78b9d20d7c7587f8e07bd5075..12f77798a0a4c86e0f86000f69690465158809e7 100644 (file)
@@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct device *dev)
 static struct iommu_group *acpihid_device_group(struct device *dev)
 {
        struct acpihid_map_entry *p, *entry = NULL;
-       u16 devid;
+       int devid;
 
        devid = get_acpihid_device_id(dev, &entry);
        if (devid < 0)