]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
leds: lp55xx: make various arrays static const
authorColin Ian King <colin.king@canonical.com>
Thu, 29 Jun 2017 17:57:38 +0000 (18:57 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Fri, 30 Jun 2017 21:15:44 +0000 (23:15 +0200)
Several arrays are currently on-stack and instead should be made
static const.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-lp5523.c

index e9ba8cd32d66071b11c7b0baf4238d13cd1cfe8d..924e50aefb0039ec88f4dfcec1ff78d4ac8f42b8 100644 (file)
@@ -168,13 +168,13 @@ static int lp5523_post_init_device(struct lp55xx_chip *chip)
 static void lp5523_load_engine(struct lp55xx_chip *chip)
 {
        enum lp55xx_engine_index idx = chip->engine_idx;
-       u8 mask[] = {
+       static const u8 mask[] = {
                [LP55XX_ENGINE_1] = LP5523_MODE_ENG1_M,
                [LP55XX_ENGINE_2] = LP5523_MODE_ENG2_M,
                [LP55XX_ENGINE_3] = LP5523_MODE_ENG3_M,
        };
 
-       u8 val[] = {
+       static const u8 val[] = {
                [LP55XX_ENGINE_1] = LP5523_LOAD_ENG1,
                [LP55XX_ENGINE_2] = LP5523_LOAD_ENG2,
                [LP55XX_ENGINE_3] = LP5523_LOAD_ENG3,
@@ -188,7 +188,7 @@ static void lp5523_load_engine(struct lp55xx_chip *chip)
 static void lp5523_load_engine_and_select_page(struct lp55xx_chip *chip)
 {
        enum lp55xx_engine_index idx = chip->engine_idx;
-       u8 page_sel[] = {
+       static const u8 page_sel[] = {
                [LP55XX_ENGINE_1] = LP5523_PAGE_ENG1,
                [LP55XX_ENGINE_2] = LP5523_PAGE_ENG2,
                [LP55XX_ENGINE_3] = LP5523_PAGE_ENG3,
@@ -208,7 +208,7 @@ static void lp5523_stop_all_engines(struct lp55xx_chip *chip)
 static void lp5523_stop_engine(struct lp55xx_chip *chip)
 {
        enum lp55xx_engine_index idx = chip->engine_idx;
-       u8 mask[] = {
+       static const u8 mask[] = {
                [LP55XX_ENGINE_1] = LP5523_MODE_ENG1_M,
                [LP55XX_ENGINE_2] = LP5523_MODE_ENG2_M,
                [LP55XX_ENGINE_3] = LP5523_MODE_ENG3_M,
@@ -505,7 +505,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
 {
        struct lp55xx_engine *engine = &chip->engines[nr - 1];
        int ret;
-       u8 mux_page[] = {
+       static const u8 mux_page[] = {
                [LP55XX_ENGINE_1] = LP5523_PAGE_MUX1,
                [LP55XX_ENGINE_2] = LP5523_PAGE_MUX2,
                [LP55XX_ENGINE_3] = LP5523_PAGE_MUX3,