]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: gadget: goku: remove unused argument
authorMichal Nazarewicz <mina86@mina86.com>
Sun, 10 Nov 2013 19:35:55 +0000 (20:35 +0100)
committerFelipe Balbi <balbi@ti.com>
Tue, 26 Nov 2013 16:58:16 +0000 (10:58 -0600)
The stop_activity function never uses driver argument (even
though it modifies it) and thus it is safe to remove it.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/goku_udc.c

index f82768015715c69ed998e2cb95cc0735dd6a035b..7eda9fd6528e395446d9bb8cbfaf589c1e43e3a8 100644 (file)
@@ -1350,16 +1350,12 @@ static int goku_udc_start(struct usb_gadget *g,
        return 0;
 }
 
-static void
-stop_activity(struct goku_udc *dev, struct usb_gadget_driver *driver)
+static void stop_activity(struct goku_udc *dev)
 {
        unsigned        i;
 
        DBG (dev, "%s\n", __func__);
 
-       if (dev->gadget.speed == USB_SPEED_UNKNOWN)
-               driver = NULL;
-
        /* disconnect gadget driver after quiesceing hw and the driver */
        udc_reset (dev);
        for (i = 0; i < 4; i++)
@@ -1377,7 +1373,7 @@ static int goku_udc_stop(struct usb_gadget *g,
 
        spin_lock_irqsave(&dev->lock, flags);
        dev->driver = NULL;
-       stop_activity(dev, driver);
+       stop_activity(dev);
        spin_unlock_irqrestore(&dev->lock, flags);
 
        return 0;
@@ -1521,7 +1517,7 @@ rescan:
        if (unlikely(stat & INT_DEVWIDE)) {
                if (stat & INT_SYSERROR) {
                        ERROR(dev, "system error\n");
-                       stop_activity(dev, dev->driver);
+                       stop_activity(dev);
                        stat = 0;
                        handled = 1;
                        // FIXME have a neater way to prevent re-enumeration
@@ -1536,7 +1532,7 @@ rescan:
                        } else {
                                DBG(dev, "disconnect\n");
                                if (dev->gadget.speed == USB_SPEED_FULL)
-                                       stop_activity(dev, dev->driver);
+                                       stop_activity(dev);
                                dev->ep0state = EP0_DISCONNECT;
                                dev->int_enable = INT_DEVWIDE;
                                writel(dev->int_enable, &dev->regs->int_enable);