]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: bridge: fix vlan stats continue counter
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Mon, 27 Jun 2016 16:34:42 +0000 (18:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Jun 2016 09:33:35 +0000 (05:33 -0400)
I made a dumb off-by-one mistake when I added the vlan stats counter
dumping code. The increment should happen before the check, not after
otherwise we miss one entry when we continue dumping.

Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_netlink.c

index a5343c7232bfbf37ca95580a70a740950354e691..85e89f693589d1a7e712d9165cdac8147e0bf02c 100644 (file)
@@ -1273,7 +1273,7 @@ static int br_fill_linkxstats(struct sk_buff *skb, const struct net_device *dev,
                struct bridge_vlan_xstats vxi;
                struct br_vlan_stats stats;
 
-               if (vl_idx++ < *prividx)
+               if (++vl_idx < *prividx)
                        continue;
                memset(&vxi, 0, sizeof(vxi));
                vxi.vid = v->vid;