]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net/fec: fix MMFR_OP type in fec_enet_mdio_write
authorShawn Guo <shawn.guo@freescale.com>
Wed, 5 Jan 2011 21:13:09 +0000 (21:13 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 17 Feb 2011 22:47:28 +0000 (14:47 -0800)
commit 862f0982eadcea0e114576c57ea426d3d51a69a6 upstream.

FEC_MMFR_OP_WRITE should be used than FEC_MMFR_OP_READ in
a mdio write operation.

It's probably a typo introduced by commit:

e6b043d512fa8d9a3801bf5d72bfa3b8fc3b3cc8
netdev/fec.c: add phylib supporting to enable carrier detection (v2)

Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/fec.c

index cce32d43175f5c3ed5f6e7ef2ebd56eede8e9139..52e9ca8de4b2694b8e89265ca542f24681e6194d 100644 (file)
@@ -651,8 +651,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
        fep->mii_timeout = 0;
        init_completion(&fep->mdio_done);
 
-       /* start a read op */
-       writel(FEC_MMFR_ST | FEC_MMFR_OP_READ |
+       /* start a write op */
+       writel(FEC_MMFR_ST | FEC_MMFR_OP_WRITE |
                FEC_MMFR_PA(mii_id) | FEC_MMFR_RA(regnum) |
                FEC_MMFR_TA | FEC_MMFR_DATA(value),
                fep->hwp + FEC_MII_DATA);