]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
tty/serial: atmel: add comment for the ring buffer size macro
authorLudovic Desroches <ludovic.desroches@atmel.com>
Fri, 17 Jun 2016 10:05:48 +0000 (12:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2016 20:38:37 +0000 (13:38 -0700)
There is a macro named ATMEL_SERIAL_RINGSIZE which suggesting that it
corresponds to the real size of the ring buffer. Let warn people that
there is a factor of four since allocation size is
sizeof(struct atmel_uart_char) * ATMEL_SERIAL_RINGSIZE.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/atmel_serial.c

index 6c1ec7d0d497c880fe68438bbebe4a95e384c447..857016367a7a9d2d8d4eb924454a9f2b6ae4ac91 100644 (file)
@@ -108,6 +108,12 @@ struct atmel_uart_char {
        u16             ch;
 };
 
+/*
+ * Be careful, the real size of the ring buffer is
+ * sizeof(atmel_uart_char) * ATMEL_SERIAL_RINGSIZE. It means that ring buffer
+ * can contain up to 1024 characters in PIO mode and up to 4096 characters in
+ * DMA mode.
+ */
 #define ATMEL_SERIAL_RINGSIZE 1024
 
 /*