]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 26 Sep 2012 01:34:53 +0000 (11:34 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 27 Sep 2012 07:28:47 +0000 (17:28 +1000)
ERROR: space required before the open parenthesis '('
#35: FILE: fs/proc/base.c:1401:
+ if(dumpable == SUID_DUMPABLE_ENABLED)

total: 1 errors, 0 warnings, 16 lines checked

./patches/coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/proc/internal.h

index 863b8c7ab4c773eae6e579a1e542fb34125926e8..cceaab07ad549caaa124b71e3db01f126052ef59 100644 (file)
@@ -103,7 +103,7 @@ static inline int task_dumpable(struct task_struct *task)
        if (mm)
                dumpable = get_dumpable(mm);
        task_unlock(task);
-       if(dumpable == SUID_DUMPABLE_ENABLED)
+       if (dumpable == SUID_DUMPABLE_ENABLED)
                return 1;
        return 0;
 }