ENGR00285273-3 IPU dev:Remove unnecessary memset before kfree

This patch removes unnecessary memset() before kfree().
Also, it fixes a potential NULL pointer dereference(writing
to a freed block of memory).

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>

diff --git a/drivers/mxc/ipu3/ipu_device.c b/drivers/mxc/ipu3/ipu_device.c
index e20241476424ed1479f229b19de6b364d8a5d24e..72a9905d5beafc745d605c11215415856b8dfe0a 100644 (file)
--- a/drivers/mxc/ipu3/ipu_device.c
+++ b/drivers/mxc/ipu3/ipu_device.c
@@ -1414,8 +1414,6 @@ static void task_mem_free(struct kref *ref)
 {
        struct ipu_task_entry *tsk =
                        container_of(ref, struct ipu_task_entry, refcount);
-
-       memset(tsk, 0, sizeof(*tsk));
        kfree(tsk);
 }
 
@@ -1731,7 +1729,6 @@ err_exit:
                if (!tsk)
                        continue;
                kfree(tsk);
-               memset(tsk, 0, sizeof(*tsk));
        }
        t->state = STATE_ERR;
        return ret;